Messages in this thread | | | Date | Thu, 2 Apr 2020 00:10:46 -0700 | From | Kees Cook <> | Subject | Re: [PATCH 1/1] platform/chrome: chromeos_pstore: set user space log size |
| |
On Wed, Apr 01, 2020 at 05:15:48PM -0700, Sarthak Kukreti wrote: > On x86 ChromiumOS devices, the pmsg_size is set to 0 (check > /sys/module/ramoops/parameters/pmsg_size): this prevents use of > pstore-pmsg, even if CONFIG_PSTORE_PMSG is enabled. Set pmsg_size > to a value that is consistent with the size used on non-x86 ChromiumOS > devices. > > Signed-off-by: Sarthak Kukreti <sarthakkukreti@chromium.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> --- > drivers/platform/chrome/chromeos_pstore.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/chrome/chromeos_pstore.c b/drivers/platform/chrome/chromeos_pstore.c > index d13770785fb5..82dea8cb5da1 100644 > --- a/drivers/platform/chrome/chromeos_pstore.c > +++ b/drivers/platform/chrome/chromeos_pstore.c > @@ -57,6 +57,7 @@ static struct ramoops_platform_data chromeos_ramoops_data = { > .record_size = 0x40000, > .console_size = 0x20000, > .ftrace_size = 0x20000, > + .pmsg_size = 0x20000, > .dump_oops = 1, > }; > > -- > 2.26.0.rc2.310.g2932bb562d-goog >
-- Kees Cook
| |