lkml.org 
[lkml]   [2020]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH][next] net: atlantic: fix missing | operator when assigning rec->llc
From
From: Colin King <colin.king@canonical.com>
Date: Thu, 2 Apr 2020 00:27:36 +0100

> From: Colin Ian King <colin.king@canonical.com>
>
> rec->llc is currently being assigned twice, once with the lower 8 bits
> from packed_record[8] and then re-assigned afterwards with data from
> packed_record[9]. This looks like a type, I believe the second assignment
> should be using the |= operator rather than a direct assignment.
>
> Addresses-Coverity: ("Unused value")
> Fixes: b8f8a0b7b5cb ("net: atlantic: MACSec ingress offload HW bindings")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks.

\
 
 \ /
  Last update: 2020-04-02 15:52    [W:1.166 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site