Messages in this thread | | | Date | Wed, 1 Apr 2020 23:15:06 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH v2]iommu/qcom:fix local_base status check |
| |
On Wed 01 Apr 23:03 PDT 2020, Tang Bin wrote:
> ------v2----------------- > As requested, add some {} around this chunk. > > ------v1-----------------
The changelog typically goes after the ---, as it doesn't add value to the resulting git log. So please drop the above 4 lines from the commit message. And please use ./scripts/get_maintainer.pl to find your recipient list.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards, Bjorn
> Release resources when exiting on error. > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > --- > drivers/iommu/qcom_iommu.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c > index 4328da0b0..c08aa9651 100644 > --- a/drivers/iommu/qcom_iommu.c > +++ b/drivers/iommu/qcom_iommu.c > @@ -813,8 +813,11 @@ static int qcom_iommu_device_probe(struct platform_device *pdev) > qcom_iommu->dev = dev; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (res) > + if (res) { > qcom_iommu->local_base = devm_ioremap_resource(dev, res); > + if (IS_ERR(qcom_iommu->local_base)) > + return PTR_ERR(qcom_iommu->local_base); > + } > > qcom_iommu->iface_clk = devm_clk_get(dev, "iface"); > if (IS_ERR(qcom_iommu->iface_clk)) { > -- > 2.20.1.windows.1 > > >
| |