Messages in this thread | | | Subject | Re: [PATCH v4 03/25] powerpc/powernv: Map & release OpenCAPI LPC memory | From | Benjamin Herrenschmidt <> | Date | Thu, 02 Apr 2020 21:41:30 +1100 |
| |
On Wed, 2020-04-01 at 01:48 -0700, Dan Williams wrote: > > > > +u64 pnv_ocxl_platform_lpc_setup(struct pci_dev *pdev, u64 size) > > +{ > > + struct pci_controller *hose = pci_bus_to_host(pdev->bus); > > + struct pnv_phb *phb = hose->private_data; > > Is calling the local variable 'hose' instead of 'host' on purpose?
Haha that's funny :-)
It's an oooooooold usage that comes iirc from sparc ? or maybe alpha ? I somewhat accidentally picked it up when adding multiple host-bridge support on powerpc in the early 2000's and it hasn't quite died yet :)
Cheers, Ben.
| |