lkml.org 
[lkml]   [2020]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [EXT] Re: [RFC PATCH v2] iommu/virtio: Use page size bitmap supported by endpoint
    On Thu, Apr 02, 2020 at 03:53:40AM +0000, Bharat Bhushan wrote:
    > > > > +struct virtio_iommu_probe_pgsize_mask {
    > > > > + struct virtio_iommu_probe_property head;
    > > > > + __u8 reserved[4];
    > > > > + __u64 pgsize_bitmap;
    > >
    > > Should be __le64
    >
    > Based on" iommu/virtio: Fix sparse warning" patch https://www.spinics.net/lists/linux-virtualization/msg41944.html changed to __u64 (not __le64)

    Yes that one was only for the virtio config struct, to play nice with
    other devices. We should still use __le for the other structures,
    including probe properties.

    Thanks,
    Jean

    >
    > Will keep __le64.
    >
    > Thanks
    > -Bharat
    >
    > >
    > > Thanks,
    > > Jean
    > >
    > > > > +};
    > > > > +
    > > > > #define VIRTIO_IOMMU_RESV_MEM_T_RESERVED 0
    > > > > #define VIRTIO_IOMMU_RESV_MEM_T_MSI 1
    > > > >

    \
     
     \ /
      Last update: 2020-04-02 11:24    [W:3.284 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site