Messages in this thread | | | Date | Thu, 2 Apr 2020 11:24:17 +0200 | From | Jean-Philippe Brucker <> | Subject | Re: [EXT] Re: [RFC PATCH v2] iommu/virtio: Use page size bitmap supported by endpoint |
| |
On Thu, Apr 02, 2020 at 03:53:40AM +0000, Bharat Bhushan wrote: > > > > +struct virtio_iommu_probe_pgsize_mask { > > > > + struct virtio_iommu_probe_property head; > > > > + __u8 reserved[4]; > > > > + __u64 pgsize_bitmap; > > > > Should be __le64 > > Based on" iommu/virtio: Fix sparse warning" patch https://www.spinics.net/lists/linux-virtualization/msg41944.html changed to __u64 (not __le64)
Yes that one was only for the virtio config struct, to play nice with other devices. We should still use __le for the other structures, including probe properties.
Thanks, Jean
> > Will keep __le64. > > Thanks > -Bharat > > > > > Thanks, > > Jean > > > > > > +}; > > > > + > > > > #define VIRTIO_IOMMU_RESV_MEM_T_RESERVED 0 > > > > #define VIRTIO_IOMMU_RESV_MEM_T_MSI 1 > > > >
| |