Messages in this thread | | | Date | Thu, 2 Apr 2020 11:19:56 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2 1/5] staging: rtl8712: fix checkpatch long-line warning |
| |
On Fri, Mar 27, 2020 at 08:08:07PM -0400, aimannajjar wrote: > This patch fixes these two long-line checkpatch warnings > in rtl871x_xmit.c: > > WARNING: line over 80 characters > \#74: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:74: > + * Please allocate memory with the sz = (struct xmit_frame) * NR_XMITFRAME, > > WARNING: line over 80 characters > \#79: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:79: > + kmalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4, GFP_ATOMIC); > > Signed-off-by: aimannajjar <aiman.najjar@hurranet.com> > --- > drivers/staging/rtl8712/rtl871x_xmit.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c > index f0b85338b567..628e4bad1547 100644 > --- a/drivers/staging/rtl8712/rtl871x_xmit.c > +++ b/drivers/staging/rtl8712/rtl871x_xmit.c > @@ -71,12 +71,13 @@ int _r8712_init_xmit_priv(struct xmit_priv *pxmitpriv, > _init_queue(&pxmitpriv->apsd_queue); > _init_queue(&pxmitpriv->free_xmit_queue); > /* > - * Please allocate memory with the sz = (struct xmit_frame) * NR_XMITFRAME, > + * Please allocate memory with sz = (struct xmit_frame) * NR_XMITFRAME, > * and initialize free_xmit_frame below. > * Please also apply free_txobj to link_up all the xmit_frames...
Probably you could delete the "Please ".
regards, dan carpenter
| |