[lkml]   [2020]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] phy: qcom-qusb2: Re add "qcom,sdm845-qusb2-phy" compat string

On Thu, Apr 2, 2020 at 3:37 PM John Stultz <> wrote:
> In commit 8fe75cd4cddf ("phy: qcom-qusb2: Add generic QUSB2 V2
> PHY support"), the change was made to add "qcom,qusb2-v2-phy"
> as a generic compat string. However the change also removed
> the "qcom,sdm845-qusb2-phy" compat string, which is documented
> in the binding and already in use.
> This patch re-adds the "qcom,sdm845-qusb2-phy" compat string
> which allows the driver to continue to work with existing dts
> entries such as found on the db845c.
> Cc: Andy Gross <>
> Cc: Bjorn Andersson <>
> Cc: Rob Herring <>
> Cc: Mark Rutland <>
> Cc: Doug Anderson <>
> Cc: Manu Gautam <>
> Cc: Sandeep Maheswaram <>
> Cc: Matthias Kaehlcke <>
> Cc: Stephen Boyd <>
> Cc: Kishon Vijay Abraham I <>
> Cc:
> Cc:
> Fixes: 8fe75cd4cddf ("phy: qcom-qusb2: Add generic QUSB2 V2 PHY support")
> Reported-by: YongQin Liu <>
> Signed-off-by: John Stultz <>
> ---
> drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 +++
> 1 file changed, 3 insertions(+)

Do you have an out-of-tree dts file? If not, I'd prefer that the fix
was for this patch to land instead:

While we can land your patch if someone needs it for supporting an
out-of-tree dts, it gives people supporting future SoCs the idea that
they need to add themselves to this table too. That's now discouraged
unless there's a specific quirk that needs to be handled just for this


 \ /
  Last update: 2020-04-03 01:03    [W:0.115 / U:6.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site