lkml.org 
[lkml]   [2020]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v19 17/18] leds: lp5523: Fix checkpatch issues in the code
    Date
    Fix checkpatch errors and warnings for the LP5523.c device
    driver.

    Signed-off-by: Dan Murphy <dmurphy@ti.com>
    Acked-by: Pavel Machek <pavel@ucw.cz>
    ---
    drivers/leds/leds-lp5523.c | 19 ++++++++++---------
    1 file changed, 10 insertions(+), 9 deletions(-)

    diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
    index 80d364f237d0..8ce278348495 100644
    --- a/drivers/leds/leds-lp5523.c
    +++ b/drivers/leds/leds-lp5523.c
    @@ -23,13 +23,13 @@

    #define LP5523_PROGRAM_LENGTH 32 /* bytes */
    /* Memory is used like this:
    - 0x00 engine 1 program
    - 0x10 engine 2 program
    - 0x20 engine 3 program
    - 0x30 engine 1 muxing info
    - 0x40 engine 2 muxing info
    - 0x50 engine 3 muxing info
    -*/
    + * 0x00 engine 1 program
    + * 0x10 engine 2 program
    + * 0x20 engine 3 program
    + * 0x30 engine 1 muxing info
    + * 0x40 engine 2 muxing info
    + * 0x50 engine 3 muxing info
    + */
    #define LP5523_MAX_LEDS 9

    /* Registers */
    @@ -326,7 +326,7 @@ static int lp5523_update_program_memory(struct lp55xx_chip *chip,
    const u8 *data, size_t size)
    {
    u8 pattern[LP5523_PROGRAM_LENGTH] = {0};
    - unsigned cmd;
    + unsigned int cmd;
    char c[3];
    int nrchars;
    int ret;
    @@ -468,6 +468,7 @@ static int lp5523_mux_parse(const char *buf, u16 *mux, size_t len)
    static void lp5523_mux_to_array(u16 led_mux, char *array)
    {
    int i, pos = 0;
    +
    for (i = 0; i < LP5523_MAX_LEDS; i++)
    pos += sprintf(array + pos, "%x", LED_ACTIVE(led_mux, i));

    @@ -506,7 +507,7 @@ static int lp5523_load_mux(struct lp55xx_chip *chip, u16 mux, int nr)
    if (ret)
    return ret;

    - ret = lp55xx_write(chip, LP5523_REG_PROG_MEM , (u8)(mux >> 8));
    + ret = lp55xx_write(chip, LP5523_REG_PROG_MEM, (u8)(mux >> 8));
    if (ret)
    return ret;

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-04-02 22:50    [W:2.988 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site