Messages in this thread | | | Date | Sun, 19 Apr 2020 05:23:40 +0200 | From | Marek Behun <> | Subject | Re: [PATCH 6/8] PCI: aardvark: Add support for issuing PERST via GPIO |
| |
On Wed, 15 Apr 2020 18:03:46 +0200 Pali Rohár <pali@kernel.org> wrote:
> + if (IS_ERR(pcie->reset_gpio)) { > + if (PTR_ERR(pcie->reset_gpio) == -ENOENT) { > + pcie->reset_gpio = NULL;
this assignment is redundant, the variable is already NULL, such structures are zeroed after allocation
> + } else { > + if (PTR_ERR(pcie->reset_gpio) != -EPROBE_DEFER) > + dev_err(dev, "Failed to retrieve reset GPIO (%ld)\n", > + PTR_ERR(pcie->reset_gpio)); > + return PTR_ERR(pcie->reset_gpio); > + } > + }
| |