Messages in this thread | | | From | Loic Poulain <> | Date | Fri, 17 Apr 2020 16:34:03 +0200 | Subject | Re: [PATCH v2] cpufreq: qcom: Add support for krait based socs |
| |
Hi Viresh, Ansuel,
On Fri, 13 Mar 2020 at 18:52, Ansuel Smith <ansuelsmth@gmail.com> wrote: > > In Certain QCOM SoCs like ipq8064, apq8064, msm8960, msm8974 > that has KRAIT processors the voltage/current value of each OPP > varies based on the silicon variant in use. > > The required OPP related data is determined based on > the efuse value. This is similar to the existing code for > kryo cores. So adding support for krait cores here. > > Signed-off-by: Sricharan R <sricharan@codeaurora.org> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > ---
> --- a/Documentation/devicetree/bindings/opp/qcom-nvmem-cpufreq.txt > +++ b/Documentation/devicetree/bindings/opp/qcom-nvmem-cpufreq.txt > @@ -19,7 +19,8 @@ In 'cpu' nodes: > In 'operating-points-v2' table: > - compatible: Should be > - - 'operating-points-v2-kryo-cpu' for apq8096 and msm8996. > + - 'operating-points-v2-kryo-cpu' for apq8096, msm8996, msm8974, > + apq8064, ipq8064, msm8960 and ipq8074.
> @@ -153,7 +277,7 @@ static int qcom_cpufreq_probe(struct platform_device *pdev) > if (!np) > return -ENOENT; > > - ret = of_device_is_compatible(np, "operating-points-v2-kryo-cpu"); > + ret = of_device_is_compatible(np, "operating-points-v2-qcom-cpu");
This breaks backward compatibility and is not aligned with the qcom-nvmem-cpufreq compatible binding.
Regards, Loic
| |