lkml.org 
[lkml]   [2020]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2] timens: show clock symbolic names in /proc/pid/timens_offsets
    Date
    Andrei Vagin <avagin@gmail.com> writes:
    > On Sat, Apr 11, 2020 at 08:40:31AM -0700, Andrei Vagin wrote:
    >> Michael Kerrisk suggested to replace numeric clock IDs on symbolic
    >> names.
    >>
    >> Now the content of these files looks like this:
    >> $ cat /proc/774/timens_offsets
    >> monotonic 864000 0
    >> boottime 1728000 0
    >>
    >> For setting offsets, both representations of clocks can be used.
    >>
    >> As for compatibility, it is acceptable to change things as long as
    >> userspace doesn't care. The format of timens_offsets files is very
    >> new and there are no userspace tools that rely on this format.
    >>
    >> But three projects crun, util-linux and criu rely on the interface of
    >> setting time offsets and this is why we need to continue supporting the
    >> clock IDs in this case.
    >>
    >> Fixes: 04a8682a71be ("fs/proc: Introduce /proc/pid/timens_offsets")
    >> Cc: Thomas Gleixner <tglx@linutronix.de>
    >> Cc: Andrew Morton <akpm@linux-foundation.org>
    >> Cc: Eric W. Biederman <ebiederm@xmission.com>
    >> Cc: Dmitry Safonov <0x7f454c46@gmail.com>
    >> Acked-by: Michael Kerrisk <mtk.manpages@gmail.com>
    >
    > Thomas and Andrew, could you merge this patch? I am sorry, I used the
    > wrong subsystem prefix. Let me know if I need to send the third version
    > of this patch.

    Picking it up.

    \
     
     \ /
      Last update: 2020-04-16 11:52    [W:3.718 / U:0.536 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site