Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH v8 4/4] kvm: vmx: virtualize split lock detection | Date | Thu, 16 Apr 2020 15:33:56 +0200 |
| |
Xiaoyao Li <xiaoyao.li@intel.com> writes: > On 4/16/2020 5:22 AM, Thomas Gleixner wrote: >> I briefly thought about renaming the flag to TIF_SLD_ENABLED, set it by >> default and update the 5 places where it is used. But that's >> inconsistent as well simply because it does not make any sense to set >> that flag when detection is not available or disabled on the command >> line. >> > > Assuming you'll pick TIF_SLD_DISABLED, I guess we need to set this flag > by default for the case SLD is no available or disabled on the command, > for consistency?
No, because nothing cares if SLD is off. There is no way to make this fully consistent under all circumstances.
Thanks,
tglx
| |