lkml.org 
[lkml]   [2020]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 005/254] staging: wilc1000: avoid double unlocking of wilc->hif_cs mutex
    Date
    From: Ajay Singh <ajay.kathat@microchip.com>

    [ Upstream commit 6c411581caef6e3b2c286871641018364c6db50a ]

    Possible double unlocking of 'wilc->hif_cs' mutex was identified by
    smatch [1]. Removed the extra call to release_bus() in
    wilc_wlan_handle_txq() which was missed in earlier commit fdc2ac1aafc6
    ("staging: wilc1000: support suspend/resume functionality").

    [1]. https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/NOEVW7C3GV74EWXJO3XX6VT2NKVB2HMT/

    Reported-by: kbuild test robot <lkp@intel.com>
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
    Link: https://lore.kernel.org/r/20200221170120.15739-1-ajay.kathat@microchip.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/wilc1000/wlan.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/staging/wilc1000/wlan.c b/drivers/staging/wilc1000/wlan.c
    index 601e4d1345d24..05b8adfe001da 100644
    --- a/drivers/staging/wilc1000/wlan.c
    +++ b/drivers/staging/wilc1000/wlan.c
    @@ -572,7 +572,6 @@ int wilc_wlan_handle_txq(struct wilc *wilc, u32 *txq_count)
    entries = ((reg >> 3) & 0x3f);
    break;
    }
    - release_bus(wilc, WILC_BUS_RELEASE_ALLOW_SLEEP);
    } while (--timeout);
    if (timeout <= 0) {
    ret = func->hif_write_reg(wilc, WILC_HOST_VMM_CTL, 0x0);
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-04-16 17:06    [W:2.798 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site