lkml.org 
[lkml]   [2020]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 120/254] MIPS: OCTEON: irq: Fix potential NULL pointer dereference
    Date
    From: Gustavo A. R. Silva <gustavo@embeddedor.com>

    commit 792a402c2840054533ef56279c212ef6da87d811 upstream.

    There is a potential NULL pointer dereference in case kzalloc()
    fails and returns NULL.

    Fix this by adding a NULL check on *cd*

    This bug was detected with the help of Coccinelle.

    Fixes: 64b139f97c01 ("MIPS: OCTEON: irq: add CIB and other fixes")
    Cc: stable@vger.kernel.org
    Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
    Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/mips/cavium-octeon/octeon-irq.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/arch/mips/cavium-octeon/octeon-irq.c
    +++ b/arch/mips/cavium-octeon/octeon-irq.c
    @@ -2199,6 +2199,9 @@ static int octeon_irq_cib_map(struct irq
    }

    cd = kzalloc(sizeof(*cd), GFP_KERNEL);
    + if (!cd)
    + return -ENOMEM;
    +
    cd->host_data = host_data;
    cd->bit = hw;


    \
     
     \ /
      Last update: 2020-04-16 16:55    [W:4.778 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site