lkml.org 
[lkml]   [2020]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 226/254] clk: ingenic/jz4770: Exit with error if CGU init failed
    Date
    From: Paul Cercueil <paul@crapouillou.net>

    commit c067b46d731a764fc46ecc466c2967088c97089e upstream.

    Exit jz4770_cgu_init() if the 'cgu' pointer we get is NULL, since the
    pointer is passed as argument to functions later on.

    Fixes: 7a01c19007ad ("clk: Add Ingenic jz4770 CGU driver")
    Cc: stable@vger.kernel.org
    Signed-off-by: Paul Cercueil <paul@crapouillou.net>
    Reported-by: kbuild test robot <lkp@intel.com>
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Link: https://lkml.kernel.org/r/20200213161952.37460-1-paul@crapouillou.net
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/clk/ingenic/jz4770-cgu.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/clk/ingenic/jz4770-cgu.c
    +++ b/drivers/clk/ingenic/jz4770-cgu.c
    @@ -432,8 +432,10 @@ static void __init jz4770_cgu_init(struc

    cgu = ingenic_cgu_new(jz4770_cgu_clocks,
    ARRAY_SIZE(jz4770_cgu_clocks), np);
    - if (!cgu)
    + if (!cgu) {
    pr_err("%s: failed to initialise CGU\n", __func__);
    + return;
    + }

    retval = ingenic_cgu_register_clocks(cgu);
    if (retval)

    \
     
     \ /
      Last update: 2020-04-16 16:31    [W:4.344 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site