lkml.org 
[lkml]   [2020]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.5 030/106] xfs: fix incorrect test in xfs_alloc_ag_vextent_lastblock
    Date
    From: "Darrick J. Wong" <darrick.wong@oracle.com>

    [ Upstream commit 77ca1eed5a7d2bf0905562eb1a15aac76bc19fe4 ]

    When I lifted the code in xfs_alloc_ag_vextent_lastblock out of a loop,
    I forgot to convert all the accesses to len to be pointer dereferences.

    Coverity-id: 1457918
    Fixes: 5113f8ec3753ed ("xfs: clean up weird while loop in xfs_alloc_ag_vextent_near")
    Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
    Reviewed-by: Brian Foster <bfoster@redhat.com>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/xfs/libxfs/xfs_alloc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
    index fc93fd88ec89f..5b0c20a0d7f2f 100644
    --- a/fs/xfs/libxfs/xfs_alloc.c
    +++ b/fs/xfs/libxfs/xfs_alloc.c
    @@ -1515,7 +1515,7 @@ xfs_alloc_ag_vextent_lastblock(
    * maxlen, go to the start of this block, and skip all those smaller
    * than minlen.
    */
    - if (len || args->alignment > 1) {
    + if (*len || args->alignment > 1) {
    acur->cnt->bc_ptrs[0] = 1;
    do {
    error = xfs_alloc_get_rec(acur->cnt, bno, len, &i);
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-04-15 14:50    [W:3.161 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site