lkml.org 
[lkml]   [2020]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 26/84] f2fs: Add a new CP flag to help fsck fix resize SPO issues
    Date
    From: Sahitya Tummala <stummala@codeaurora.org>

    [ Upstream commit c84ef3c5e65ccf99a7a91a4d731ebb5d6331a178 ]

    Add and set a new CP flag CP_RESIZEFS_FLAG during
    online resize FS to help fsck fix the metadata mismatch
    that may happen due to SPO during resize, where SB
    got updated but CP data couldn't be written yet.

    fsck errors -
    Info: CKPT version = 6ed7bccb
    Wrong user_block_count(2233856)
    [f2fs_do_mount:3365] Checkpoint is polluted

    Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
    Reviewed-by: Chao Yu <yuchao0@huawei.com>
    Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/f2fs/checkpoint.c | 8 ++++++--
    include/linux/f2fs_fs.h | 1 +
    2 files changed, 7 insertions(+), 2 deletions(-)

    diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
    index 410f5c2c6ef17..a28ffecc0f95a 100644
    --- a/fs/f2fs/checkpoint.c
    +++ b/fs/f2fs/checkpoint.c
    @@ -1301,10 +1301,14 @@ static void update_ckpt_flags(struct f2fs_sb_info *sbi, struct cp_control *cpc)
    else
    __clear_ckpt_flags(ckpt, CP_ORPHAN_PRESENT_FLAG);

    - if (is_sbi_flag_set(sbi, SBI_NEED_FSCK) ||
    - is_sbi_flag_set(sbi, SBI_IS_RESIZEFS))
    + if (is_sbi_flag_set(sbi, SBI_NEED_FSCK))
    __set_ckpt_flags(ckpt, CP_FSCK_FLAG);

    + if (is_sbi_flag_set(sbi, SBI_IS_RESIZEFS))
    + __set_ckpt_flags(ckpt, CP_RESIZEFS_FLAG);
    + else
    + __clear_ckpt_flags(ckpt, CP_RESIZEFS_FLAG);
    +
    if (is_sbi_flag_set(sbi, SBI_CP_DISABLED))
    __set_ckpt_flags(ckpt, CP_DISABLED_FLAG);
    else
    diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h
    index 2847389960281..6bb6f718a1023 100644
    --- a/include/linux/f2fs_fs.h
    +++ b/include/linux/f2fs_fs.h
    @@ -124,6 +124,7 @@ struct f2fs_super_block {
    /*
    * For checkpoint
    */
    +#define CP_RESIZEFS_FLAG 0x00004000
    #define CP_DISABLED_QUICK_FLAG 0x00002000
    #define CP_DISABLED_FLAG 0x00001000
    #define CP_QUOTA_NEED_FSCK_FLAG 0x00000800
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-04-15 14:28    [W:4.105 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site