lkml.org 
[lkml]   [2020]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 61/84] drm/amdkfd: kfree the wrong pointer
    Date
    From: Jack Zhang <Jack.Zhang1@amd.com>

    [ Upstream commit 3148a6a0ef3cf93570f30a477292768f7eb5d3c3 ]

    Originally, it kfrees the wrong pointer for mem_obj.
    It would cause memory leak under stress test.

    Signed-off-by: Jack Zhang <Jack.Zhang1@amd.com>
    Acked-by: Nirmoy Das <nirmoy.das@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/amdkfd/kfd_device.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
    index 0dc1084b5e829..ad9483b9eea32 100644
    --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
    +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
    @@ -1112,9 +1112,9 @@ int kfd_gtt_sa_allocate(struct kfd_dev *kfd, unsigned int size,
    return 0;

    kfd_gtt_no_free_chunk:
    - pr_debug("Allocation failed with mem_obj = %p\n", mem_obj);
    + pr_debug("Allocation failed with mem_obj = %p\n", *mem_obj);
    mutex_unlock(&kfd->gtt_sa_lock);
    - kfree(mem_obj);
    + kfree(*mem_obj);
    return -ENOMEM;
    }

    --
    2.20.1
    \
     
     \ /
      Last update: 2020-04-15 14:22    [W:4.322 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site