lkml.org 
[lkml]   [2020]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.6 029/129] arm64: dts: clearfog-gt-8k: set gigabit PHY reset deassert delay
    Date
    From: Russell King <rmk+kernel@armlinux.org.uk>

    [ Upstream commit 46f94c7818e7ab82758fca74935ef3d454340b4e ]

    If the mv88e6xxx DSA driver is built as a module, it causes the
    ethernet driver to re-probe when it's loaded. This in turn causes
    the gigabit PHY to be momentarily reset and reprogrammed. However,
    we attempt to reprogram the PHY immediately after deasserting reset,
    and the PHY ignores the writes.

    This results in the PHY operating in the wrong mode, and the copper
    link states down.

    Set a reset deassert delay of 10ms for the gigabit PHY to avoid this.

    Fixes: babc5544c293 ("arm64: dts: clearfog-gt-8k: 1G eth PHY reset signal")
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Acked-by: Baruch Siach <baruch@tkos.co.il>
    Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
    index a211a046b2f2f..b90d78a5724b2 100644
    --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
    +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
    @@ -367,6 +367,7 @@
    pinctrl-0 = <&cp0_copper_eth_phy_reset>;
    reset-gpios = <&cp0_gpio2 11 GPIO_ACTIVE_LOW>;
    reset-assert-us = <10000>;
    + reset-deassert-us = <10000>;
    };

    switch0: switch0@4 {
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-04-15 13:40    [W:4.042 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site