lkml.org 
[lkml]   [2020]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 4/8] arm64: cpufeature: Remove redundant call to id_aa64pfr0_32bit_el0()
    From
    Date
    On 04/14/2020 10:31 PM, Will Deacon wrote:
    > There's no need to call id_aa64pfr0_32bit_el0() twice because the
    > sanitised value of ID_AA64PFR0_EL1 has already been updated for the CPU
    > being onlined.
    >
    > Remove the redundant function call.
    >
    > Signed-off-by: Will Deacon <will@kernel.org>

    Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>

    > ---
    > arch/arm64/kernel/cpufeature.c | 4 +---
    > 1 file changed, 1 insertion(+), 3 deletions(-)
    >
    > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
    > index 838fe5cc8d7e..7dfcdd9e75c1 100644
    > --- a/arch/arm64/kernel/cpufeature.c
    > +++ b/arch/arm64/kernel/cpufeature.c
    > @@ -792,9 +792,7 @@ void update_cpu_features(int cpu,
    > * If we have AArch32, we care about 32-bit features for compat.
    > * If the system doesn't support AArch32, don't update them.
    > */
    > - if (id_aa64pfr0_32bit_el0(read_sanitised_ftr_reg(SYS_ID_AA64PFR0_EL1)) &&
    > - id_aa64pfr0_32bit_el0(info->reg_id_aa64pfr0)) {
    > -
    > + if (id_aa64pfr0_32bit_el0(read_sanitised_ftr_reg(SYS_ID_AA64PFR0_EL1))) {
    > taint |= check_update_ftr_reg(SYS_ID_DFR0_EL1, cpu,
    > info->reg_id_dfr0, boot->reg_id_dfr0);
    > taint |= check_update_ftr_reg(SYS_ID_ISAR0_EL1, cpu,
    >

    \
     
     \ /
      Last update: 2020-04-15 12:31    [W:2.897 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site