Messages in this thread | | | Subject | Re: [PATCH v9 0/6] Add battery charger driver support for MP2629 | From | saravanan sekar <> | Date | Wed, 15 Apr 2020 18:53:30 +0200 |
| |
Hi Andy,
On 15/04/20 6:40 pm, Andy Shevchenko wrote: > On Wed, Apr 15, 2020 at 7:20 PM Saravanan Sekar <sravanhome@gmail.com> wrote: >> changes in v9: >> - fixed review comments in mp2629 power supply such as resource based >> iio channel, replace workqueue by threaded irq, irq get with "_optional" >> > May I ask you why you are ignoring my tag? > If you don't want to have your patches reviewed / applied, just don't send them.
Sorry last time it was by mistake. But now I have added in below, if suppose to added in top its my ignorance
> >> changes in v8: >> - fixed order of call in probe/remove in iio adc >> - add ABI documentation for mp2629 power supply >> >> changes in v7: >> - fixed probe/remove order, managed and unmanaged call mix use in adc. >> - Documentation dual license, i2c node with controller address >> >> Overall looks good to me, FWIW, >> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> >> >> One question though in reply to patch 4.
Please see here, this is first experience of tag in cover letter so just kept here as you gave against v7
>> >> changes in v6: >> - removed includes types.h in mfd, of_device.h in adc. >> - fixed review comments parentheses, err check, kstrtouint >> >> changes in v5: >> - removed platfrom data stored in mfd and directly accessed mfd struct in child >> - fixed spell check and capitalization in mfd and documentation >> >> changes in v4: >> - fixed capitalization in mfg Kconfig and documentation >> >> changes in v3: >> - regmap for children passed using platform data and remove mfd driver info >> access directly from children >> >> changes in v2: >> - removed EXPORT_SYMBOL of register set/get helper >> - regmap bit filed used, fixed other review comments >> >> This patch series add support for Battery charger control driver for Monolithic >> Power System's MP2629 chipset, includes MFD driver for ADC battery & input >> power supply measurement and battery charger control driver. >> >> Thanks, >> Saravanan >> >> Saravanan Sekar (6): >> dt-bindings: mfd: add document bindings for mp2629 >> mfd: mp2629: Add support for mps battery charger >> iio: adc: mp2629: Add support for mp2629 ADC driver >> power: supply: Add support for mps mp2629 battery charger >> power: supply: mp2629: Add impedance compenstation config >> MAINTAINERS: Add entry for mp2629 Battery Charger driver >> >> .../ABI/testing/sysfs-class-power-mp2629 | 8 + >> .../devicetree/bindings/mfd/mps,mp2629.yaml | 60 ++ >> MAINTAINERS | 5 + >> drivers/iio/adc/Kconfig | 10 + >> drivers/iio/adc/Makefile | 1 + >> drivers/iio/adc/mp2629_adc.c | 208 ++++++ >> drivers/mfd/Kconfig | 9 + >> drivers/mfd/Makefile | 2 + >> drivers/mfd/mp2629.c | 86 +++ >> drivers/power/supply/Kconfig | 10 + >> drivers/power/supply/Makefile | 1 + >> drivers/power/supply/mp2629_charger.c | 667 ++++++++++++++++++ >> include/linux/mfd/mp2629.h | 28 + >> 13 files changed, 1095 insertions(+) >> create mode 100644 Documentation/ABI/testing/sysfs-class-power-mp2629 >> create mode 100644 Documentation/devicetree/bindings/mfd/mps,mp2629.yaml >> create mode 100644 drivers/iio/adc/mp2629_adc.c >> create mode 100644 drivers/mfd/mp2629.c >> create mode 100644 drivers/power/supply/mp2629_charger.c >> create mode 100644 include/linux/mfd/mp2629.h >> >> -- >> 2.17.1 >> >
| |