lkml.org 
[lkml]   [2020]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.6 045/129] f2fs: Fix mount failure due to SPO after a successful online resize FS
    Date
    From: Sahitya Tummala <stummala@codeaurora.org>

    [ Upstream commit 682756827501dc52593bf490f2d437c65ec9efcb ]

    Even though online resize is successfully done, a SPO immediately
    after resize, still causes below error in the next mount.

    [ 11.294650] F2FS-fs (sda8): Wrong user_block_count: 2233856
    [ 11.300272] F2FS-fs (sda8): Failed to get valid F2FS checkpoint

    This is because after FS metadata is updated in update_fs_metadata()
    if the SBI_IS_DIRTY is not dirty, then CP will not be done to reflect
    the new user_block_count.

    Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
    Reviewed-by: Chao Yu <yuchao0@huawei.com>
    Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/f2fs/gc.c | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
    index 9cff2502e3bc6..2f645c591a000 100644
    --- a/fs/f2fs/gc.c
    +++ b/fs/f2fs/gc.c
    @@ -1579,11 +1579,17 @@ int f2fs_resize_fs(struct f2fs_sb_info *sbi, __u64 block_count)
    goto out;
    }

    + mutex_lock(&sbi->cp_mutex);
    update_fs_metadata(sbi, -secs);
    clear_sbi_flag(sbi, SBI_IS_RESIZEFS);
    + set_sbi_flag(sbi, SBI_IS_DIRTY);
    + mutex_unlock(&sbi->cp_mutex);
    +
    err = f2fs_sync_fs(sbi->sb, 1);
    if (err) {
    + mutex_lock(&sbi->cp_mutex);
    update_fs_metadata(sbi, secs);
    + mutex_unlock(&sbi->cp_mutex);
    update_sb_metadata(sbi, secs);
    f2fs_commit_super(sbi, false);
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-04-15 15:41    [W:4.115 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site