Messages in this thread | | | Subject | Re: [PATCH 4/4] power: supply: core: Constify properties | From | Enric Balletbo i Serra <> | Date | Tue, 14 Apr 2020 17:57:42 +0200 |
| |
Hi Sebastian,
On 13/4/20 20:38, Sebastian Reichel wrote: > properties is a list of properties supported by the > driver. It is not modified by the power-supply core > and drivers are not supposed to change it once the > list has been registered. Let's mark it as const for > improved security. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> --- > include/linux/power_supply.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h > index 0392c9cc8f1c..6a34df65d4d1 100644 > --- a/include/linux/power_supply.h > +++ b/include/linux/power_supply.h > @@ -225,7 +225,7 @@ struct power_supply_desc { > enum power_supply_type type; > const enum power_supply_usb_type *usb_types; > size_t num_usb_types; > - enum power_supply_property *properties; > + const enum power_supply_property *properties; > size_t num_properties; > > /* >
| |