Messages in this thread | | | Date | Tue, 14 Apr 2020 08:22:04 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH V7 2/9] fs: Remove unneeded IS_DAX() check in io_is_direct() |
| |
On Sun, Apr 12, 2020 at 10:40:39PM -0700, ira.weiny@intel.com wrote: > From: Ira Weiny <ira.weiny@intel.com> > > Remove the check because DAX now has it's own read/write methods and > file systems which support DAX check IS_DAX() prior to IOCB_DIRECT on > their own. Therefore, it does not matter if the file state is DAX when > the iocb flags are created. > > Also remove io_is_direct() as it is just a simple flag check. > > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |