lkml.org 
[lkml]   [2020]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH -next] bpf: remove set but not used variable 'dst_known'
    From
    Date
    On 2020/4/15 6:05, Song Liu wrote:
    >
    >
    >> On Apr 13, 2020, at 4:37 AM, Mao Wenan <maowenan@huawei.com> wrote:
    >>
    >> Fixes gcc '-Wunused-but-set-variable' warning:
    >>
    >> kernel/bpf/verifier.c:5603:18: warning: variable ‘dst_known’
    >> set but not used [-Wunused-but-set-variable]
    >>
    >> It is not used since commit f1174f77b50c ("bpf/verifier:
    >> rework value tracking")
    >
    > The fix makes sense. But I think f1174f77b50c introduced dst_known,
    > so this statement is not accurate.
    >
    thanks for review, yes, f1174f77b50c introduced dst_known, and below commit
    doesn't deference variable dst_known. So I send v2 later?
    3f50f132d840 ("bpf: Verifier, do explicit ALU32 bounds tracking")

    >>
    >> Signed-off-by: Mao Wenan <maowenan@huawei.com>
    >


    \
     
     \ /
      Last update: 2020-04-15 03:38    [W:4.100 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site