lkml.org 
[lkml]   [2020]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] pwm: Add missing '\n' in log messages
From
Date
On Tue, 2020-04-14 at 21:49 +0300, Dan Carpenter wrote:
> Huh...
>
> If you look at dev_vprintk_emit(). It looks like if
> create_syslog_header() returns a string then vprintk_store() will add
> a newline.
>
> I guess that means that dev_printk() can't be used to pr_cont(). And
> probably that's deliberate because using pr_cont() after boot is racy
> anyway.

Perhaps that's true, it didn't used to be.

There are couple dozen or so KERN_CONT uses after a dev_<level>
without a newline, so those _might_ be broken, but I don't thinks so.

$ git grep -P -A10 '\bdev_\w+\s*\(' | \
grep -P -B10 "KERN_CONT|pr_cont"

\
 
 \ /
  Last update: 2020-04-14 21:29    [W:0.098 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site