Messages in this thread | | | Date | Tue, 14 Apr 2020 21:41:55 +0300 | From | Leon Romanovsky <> | Subject | Re: [PATCH net-next 4/4] kernel/module: Hide vermagic header file from general use |
| |
On Tue, Apr 14, 2020 at 06:03:50PM +0200, Borislav Petkov wrote: > On Tue, Apr 14, 2020 at 06:57:32PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky <leonro@mellanox.com> > > > > VERMAGIC* definitions are not supposed to be used by the drivers, > > Yeah, this was only me conjecturing here. But yes, if people agree, this > would be one way to do it. > > In any case and FWIW, series looks ok to me: > > Acked-by: Borislav Petkov <bp@suse.de>
Thanks, finally kbuild slap me to the face. There is a need to change scripts/mod/modpost.c too and find the reason why I didn't get any compilation errors.
<...> >> drivers/gpio/gpio-aspeed.mod.c:3:10: fatal error: linux/vermagic.h: No such file or directory 3 | #include <linux/vermagic.h> | ^~~~~~~~~~~~~~~~~~ compilation terminated.
<...>
> > Thx. > > -- > Regards/Gruss, > Boris. > > SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
| |