lkml.org 
[lkml]   [2020]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] libertas: make lbs_process_event() void
    Date
    Fix the following coccicheck warning:

    drivers/net/wireless/marvell/libertas/cmdresp.c:225:5-8: Unneeded
    variable: "ret". Return "0" on line 355

    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Jason Yan <yanaijie@huawei.com>
    ---
    drivers/net/wireless/marvell/libertas/cmd.h | 2 +-
    drivers/net/wireless/marvell/libertas/cmdresp.c | 5 +----
    2 files changed, 2 insertions(+), 5 deletions(-)

    diff --git a/drivers/net/wireless/marvell/libertas/cmd.h b/drivers/net/wireless/marvell/libertas/cmd.h
    index 80878561cb90..3c193074662b 100644
    --- a/drivers/net/wireless/marvell/libertas/cmd.h
    +++ b/drivers/net/wireless/marvell/libertas/cmd.h
    @@ -76,7 +76,7 @@ void lbs_mac_event_disconnected(struct lbs_private *priv,

    /* Events */

    -int lbs_process_event(struct lbs_private *priv, u32 event);
    +void lbs_process_event(struct lbs_private *priv, u32 event);


    /* Actual commands */
    diff --git a/drivers/net/wireless/marvell/libertas/cmdresp.c b/drivers/net/wireless/marvell/libertas/cmdresp.c
    index b73d08381398..cb515c5584c1 100644
    --- a/drivers/net/wireless/marvell/libertas/cmdresp.c
    +++ b/drivers/net/wireless/marvell/libertas/cmdresp.c
    @@ -220,9 +220,8 @@ int lbs_process_command_response(struct lbs_private *priv, u8 *data, u32 len)
    return ret;
    }

    -int lbs_process_event(struct lbs_private *priv, u32 event)
    +void lbs_process_event(struct lbs_private *priv, u32 event)
    {
    - int ret = 0;
    struct cmd_header cmd;

    switch (event) {
    @@ -351,6 +350,4 @@ int lbs_process_event(struct lbs_private *priv, u32 event)
    netdev_alert(priv->dev, "EVENT: unknown event id %d\n", event);
    break;
    }
    -
    - return ret;
    }
    --
    2.21.1
    \
     
     \ /
      Last update: 2020-04-13 09:54    [W:3.758 / U:0.820 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site