lkml.org 
[lkml]   [2020]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] scsi: sg: fix memory leak in sg_build_indirect
From
Date
On 2020-04-13 3:35 p.m., Markus Elfring wrote:
>> Fix a memory leak when there have failed, that we should free the pages
>> under the condition rem_sz > 0.
>
> I suggest to improve the change description.
>
> * Please use an imperative wording.

nominative, vocative, accusative, genitive ...

I have made some comment suggestions in response to the original posts
from the author.

> * Will the tag “Fixes” become relevant?

Yes, both patches from the author are fixes. These leaks would typically
appear on a system under resource pressure (specifically low memory) and
would tend to make the situation worse.

Doug Gilbert


\
 
 \ /
  Last update: 2020-04-14 03:39    [W:0.051 / U:0.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site