Messages in this thread | | | Subject | Re: [PATCH] scsi: sg: fix memory leak in sg_build_indirect | From | Douglas Gilbert <> | Date | Mon, 13 Apr 2020 21:39:04 -0400 |
| |
On 2020-04-13 3:35 p.m., Markus Elfring wrote: >> Fix a memory leak when there have failed, that we should free the pages >> under the condition rem_sz > 0. > > I suggest to improve the change description. > > * Please use an imperative wording.
nominative, vocative, accusative, genitive ...
I have made some comment suggestions in response to the original posts from the author.
> * Will the tag “Fixes” become relevant?
Yes, both patches from the author are fixes. These leaks would typically appear on a system under resource pressure (specifically low memory) and would tend to make the situation worse.
Doug Gilbert
| |