Messages in this thread | | | Date | Mon, 13 Apr 2020 15:25:46 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH 2/4] drivers: pci: dwc: pci-imx6: update binding to generic name |
| |
If/when you repost this, please update the subject to match the convention:
$ git log --oneline drivers/pci/controller/dwc/pci-imx6.c 2170a09fb4b0 PCI: imx6: Propagate errors for optional regulators 075af61c19cd PCI: imx6: Limit DBI register length 1b8df7aa7874 PCI: imx6: Allow asynchronous probing 87cb312777b5 PCI: imx6: Use usleep_range() in imx6_pcie_enable_ref_clk()
As Fabio pointed out, we can't break backward compatibility without a good reason.
On Fri, Apr 10, 2020 at 02:47:36AM +0200, Ansuel Smith wrote: > Rename specific bindings to generic name. > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > --- > drivers/pci/controller/dwc/pci-imx6.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index acfbd34032a8..4ac140e007b4 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -1146,28 +1146,28 @@ static int imx6_pcie_probe(struct platform_device *pdev) > } > > /* Grab PCIe PHY Tx Settings */ > - if (of_property_read_u32(node, "fsl,tx-deemph-gen1", > + if (of_property_read_u32(node, "tx-deemph-gen1", > &imx6_pcie->tx_deemph_gen1)) > imx6_pcie->tx_deemph_gen1 = 0; > > - if (of_property_read_u32(node, "fsl,tx-deemph-gen2-3p5db", > + if (of_property_read_u32(node, "tx-deemph-gen2-3p5db", > &imx6_pcie->tx_deemph_gen2_3p5db)) > imx6_pcie->tx_deemph_gen2_3p5db = 0; > > - if (of_property_read_u32(node, "fsl,tx-deemph-gen2-6db", > + if (of_property_read_u32(node, "tx-deemph-gen2-6db", > &imx6_pcie->tx_deemph_gen2_6db)) > imx6_pcie->tx_deemph_gen2_6db = 20; > > - if (of_property_read_u32(node, "fsl,tx-swing-full", > + if (of_property_read_u32(node, "tx-swing-full", > &imx6_pcie->tx_swing_full)) > imx6_pcie->tx_swing_full = 127; > > - if (of_property_read_u32(node, "fsl,tx-swing-low", > + if (of_property_read_u32(node, "tx-swing-low", > &imx6_pcie->tx_swing_low)) > imx6_pcie->tx_swing_low = 127; > > /* Limit link speed */ > - ret = of_property_read_u32(node, "fsl,max-link-speed", > + ret = of_property_read_u32(node, "max-link-speed", > &imx6_pcie->link_gen); > if (ret) > imx6_pcie->link_gen = 1; > -- > 2.25.1 >
| |