Messages in this thread | | | From | Baolin Wang <> | Date | Mon, 13 Apr 2020 10:55:49 +0800 | Subject | Re: [PATCH 1/2] drivers/clocksource/timer-of: Remove __init markings |
| |
Hi Daniel,
On Tue, Mar 24, 2020 at 1:59 PM Baolin Wang <baolin.wang7@gmail.com> wrote: > > From: Saravana Kannan <saravanak@google.com> > > This allows timer drivers to be compiled as modules. > > Signed-off-by: Saravana Kannan <saravanak@google.com> > Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
Do you have any comments for this patch set? Thanks.
> --- > drivers/clocksource/timer-of.c | 17 +++++++++-------- > drivers/clocksource/timer-of.h | 4 ++-- > 2 files changed, 11 insertions(+), 10 deletions(-) > > diff --git a/drivers/clocksource/timer-of.c b/drivers/clocksource/timer-of.c > index 572da47..fd3b868 100644 > --- a/drivers/clocksource/timer-of.c > +++ b/drivers/clocksource/timer-of.c > @@ -19,7 +19,7 @@ > * > * Free the irq resource > */ > -static __init void timer_of_irq_exit(struct of_timer_irq *of_irq) > +static void timer_of_irq_exit(struct of_timer_irq *of_irq) > { > struct timer_of *to = container_of(of_irq, struct timer_of, of_irq); > > @@ -47,7 +47,7 @@ static __init void timer_of_irq_exit(struct of_timer_irq *of_irq) > * > * Returns 0 on success, < 0 otherwise > */ > -static __init int timer_of_irq_init(struct device_node *np, > +static int timer_of_irq_init(struct device_node *np, > struct of_timer_irq *of_irq) > { > int ret; > @@ -91,7 +91,7 @@ static __init int timer_of_irq_init(struct device_node *np, > * > * Disables and releases the refcount on the clk > */ > -static __init void timer_of_clk_exit(struct of_timer_clk *of_clk) > +static void timer_of_clk_exit(struct of_timer_clk *of_clk) > { > of_clk->rate = 0; > clk_disable_unprepare(of_clk->clk); > @@ -107,7 +107,7 @@ static __init void timer_of_clk_exit(struct of_timer_clk *of_clk) > * > * Returns 0 on success, < 0 otherwise > */ > -static __init int timer_of_clk_init(struct device_node *np, > +static int timer_of_clk_init(struct device_node *np, > struct of_timer_clk *of_clk) > { > int ret; > @@ -146,12 +146,12 @@ static __init int timer_of_clk_init(struct device_node *np, > goto out; > } > > -static __init void timer_of_base_exit(struct of_timer_base *of_base) > +static void timer_of_base_exit(struct of_timer_base *of_base) > { > iounmap(of_base->base); > } > > -static __init int timer_of_base_init(struct device_node *np, > +static int timer_of_base_init(struct device_node *np, > struct of_timer_base *of_base) > { > of_base->base = of_base->name ? > @@ -165,7 +165,7 @@ static __init int timer_of_base_init(struct device_node *np, > return 0; > } > > -int __init timer_of_init(struct device_node *np, struct timer_of *to) > +int timer_of_init(struct device_node *np, struct timer_of *to) > { > int ret = -EINVAL; > int flags = 0; > @@ -209,6 +209,7 @@ int __init timer_of_init(struct device_node *np, struct timer_of *to) > timer_of_base_exit(&to->of_base); > return ret; > } > +EXPORT_SYMBOL_GPL(timer_of_init); > > /** > * timer_of_cleanup - release timer_of ressources > @@ -217,7 +218,7 @@ int __init timer_of_init(struct device_node *np, struct timer_of *to) > * Release the ressources that has been used in timer_of_init(). > * This function should be called in init error cases > */ > -void __init timer_of_cleanup(struct timer_of *to) > +void timer_of_cleanup(struct timer_of *to) > { > if (to->flags & TIMER_OF_IRQ) > timer_of_irq_exit(&to->of_irq); > diff --git a/drivers/clocksource/timer-of.h b/drivers/clocksource/timer-of.h > index a5478f3..1b8cfac5 100644 > --- a/drivers/clocksource/timer-of.h > +++ b/drivers/clocksource/timer-of.h > @@ -66,9 +66,9 @@ static inline unsigned long timer_of_period(struct timer_of *to) > return to->of_clk.period; > } > > -extern int __init timer_of_init(struct device_node *np, > +extern int timer_of_init(struct device_node *np, > struct timer_of *to); > > -extern void __init timer_of_cleanup(struct timer_of *to); > +extern void timer_of_cleanup(struct timer_of *to); > > #endif > -- > 1.9.1 >
-- Baolin Wang
| |