lkml.org 
[lkml]   [2020]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 107/108] rtc: imx-sc: Align imx sc msg structs to 4
    Date
    From: Leonard Crestez <leonard.crestez@nxp.com>

    [ Upstream commit a29de86521d8a80cb0b426638d4e38707cafa2e2 ]

    The imx SC api strongly assumes that messages are composed out of
    4-bytes words but some of our message structs have odd sizeofs.

    This produces many oopses with CONFIG_KASAN=y.

    Fix by marking with __aligned(4).

    Fixes: a3094fc1a15e ("rtc: imx-sc: add rtc alarm support")
    Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
    Link: https://lore.kernel.org/r/13404bac8360852d86c61fad5ae5f0c91ffc4cb6.1582216144.git.leonard.crestez@nxp.com
    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/rtc/rtc-imx-sc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/rtc/rtc-imx-sc.c b/drivers/rtc/rtc-imx-sc.c
    index cf2c12107f2b8..a5f59e6f862e0 100644
    --- a/drivers/rtc/rtc-imx-sc.c
    +++ b/drivers/rtc/rtc-imx-sc.c
    @@ -37,7 +37,7 @@ struct imx_sc_msg_timer_rtc_set_alarm {
    u8 hour;
    u8 min;
    u8 sec;
    -} __packed;
    +} __packed __aligned(4);

    static int imx_sc_rtc_read_time(struct device *dev, struct rtc_time *tm)
    {
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-04-12 01:27    [W:4.081 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site