lkml.org 
[lkml]   [2020]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Drivers: hv: vmbus: Fix Suspend-to-Idle for Generation-2 VM
Hi Dexuan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.6 next-20200410]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Dexuan-Cui/Drivers-hv-vmbus-Fix-Suspend-to-Idle-for-Generation-2-VM/20200411-061907
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c0cc271173b2e1c2d8d0ceaef14e4dfa79eefc0d
config: x86_64-randconfig-h003-20200410 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/hv/vmbus_drv.c:984:18: error: 'vmbus_suspend' undeclared here (not in a function); did you mean 'vmbus_uevent'?
.freeze_noirq = vmbus_suspend,
^~~~~~~~~~~~~
vmbus_uevent
>> drivers/hv/vmbus_drv.c:985:16: error: 'vmbus_resume' undeclared here (not in a function); did you mean 'vmbus_remove'?
.thaw_noirq = vmbus_resume,
^~~~~~~~~~~~
vmbus_remove
>> drivers/hv/vmbus_drv.c:2291:18: error: 'vmbus_bus_suspend' undeclared here (not in a function); did you mean 'vmbus_suspend'?
.freeze_noirq = vmbus_bus_suspend,
^~~~~~~~~~~~~~~~~
vmbus_suspend
>> drivers/hv/vmbus_drv.c:2292:16: error: 'vmbus_bus_resume' undeclared here (not in a function); did you mean 'vmbus_resume'?
.thaw_noirq = vmbus_bus_resume,
^~~~~~~~~~~~~~~~
vmbus_resume

vim +984 drivers/hv/vmbus_drv.c

970
971 /*
972 * Note: we must use the "noirq" ops: see the comment before vmbus_bus_pm.
973 *
974 * suspend_noirq/resume_noirq are set to NULL to support Suspend-to-Idle: we
975 * shouldn't suspend the vmbus devices upon Suspend-to-Idle, otherwise there
976 * is no way to wake up a Generation-2 VM.
977 *
978 * The other 4 ops are for hibernation.
979 */
980
981 static const struct dev_pm_ops vmbus_pm = {
982 .suspend_noirq = NULL,
983 .resume_noirq = NULL,
> 984 .freeze_noirq = vmbus_suspend,
> 985 .thaw_noirq = vmbus_resume,
986 .poweroff_noirq = vmbus_suspend,
987 .restore_noirq = vmbus_resume,
988 };
989

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2020-04-11 05:57    [W:0.207 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site