lkml.org 
[lkml]   [2020]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 048/116] Input: raydium_i2c_ts - fix error codes in raydium_i2c_boot_trigger()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 32cf3a610c35cb21e3157f4bbf29d89960e30a36 upstream.

    These functions are supposed to return negative error codes but instead
    it returns true on failure and false on success. The error codes are
    eventually propagated back to user space.

    Fixes: 48a2b783483b ("Input: add Raydium I2C touchscreen driver")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Link: https://lore.kernel.org/r/20200303101306.4potflz7na2nn3od@kili.mountain
    Cc: stable@vger.kernel.org
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/input/touchscreen/raydium_i2c_ts.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/drivers/input/touchscreen/raydium_i2c_ts.c
    +++ b/drivers/input/touchscreen/raydium_i2c_ts.c
    @@ -441,7 +441,7 @@ static int raydium_i2c_write_object(stru
    return 0;
    }

    -static bool raydium_i2c_boot_trigger(struct i2c_client *client)
    +static int raydium_i2c_boot_trigger(struct i2c_client *client)
    {
    static const u8 cmd[7][6] = {
    { 0x08, 0x0C, 0x09, 0x00, 0x50, 0xD7 },
    @@ -466,10 +466,10 @@ static bool raydium_i2c_boot_trigger(str
    }
    }

    - return false;
    + return 0;
    }

    -static bool raydium_i2c_fw_trigger(struct i2c_client *client)
    +static int raydium_i2c_fw_trigger(struct i2c_client *client)
    {
    static const u8 cmd[5][11] = {
    { 0, 0x09, 0x71, 0x0C, 0x09, 0x00, 0x50, 0xD7, 0, 0, 0 },
    @@ -492,7 +492,7 @@ static bool raydium_i2c_fw_trigger(struc
    }
    }

    - return false;
    + return 0;
    }

    static int raydium_i2c_check_path(struct i2c_client *client)

    \
     
     \ /
      Last update: 2020-04-01 18:25    [W:4.529 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site