lkml.org 
[lkml]   [2020]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/32] staging: wfx: do not stop mac80211 queueing during tx_policy upload
    Date
    From: Jérôme Pouiller <jerome.pouiller@silabs.com>

    When a new tx_policy has to be uploaded, it is necessary to avoid any
    race between the frame and the policy. So, the driver stops the tx queue
    during tx_policy upload. However, it is not necessary to stop mac80211
    queuing.

    Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
    ---
    drivers/staging/wfx/data_tx.c | 10 +---------
    1 file changed, 1 insertion(+), 9 deletions(-)

    diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
    index 42183c70d4df..7a7c2518f6cf 100644
    --- a/drivers/staging/wfx/data_tx.c
    +++ b/drivers/staging/wfx/data_tx.c
    @@ -244,9 +244,7 @@ void wfx_tx_policy_upload_work(struct work_struct *work)
    container_of(work, struct wfx_vif, tx_policy_upload_work);

    wfx_tx_policy_upload(wvif);
    -
    wfx_tx_unlock(wvif->wdev);
    - wfx_tx_queues_unlock(wvif->wdev);
    }

    void wfx_tx_policy_init(struct wfx_vif *wvif)
    @@ -379,15 +377,9 @@ static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
    dev_warn(wvif->wdev->dev, "unable to get a valid Tx policy");

    if (tx_policy_renew) {
    - /* FIXME: It's not so optimal to stop TX queues every now and
    - * then. Better to reimplement task scheduling with a counter.
    - */
    wfx_tx_lock(wvif->wdev);
    - wfx_tx_queues_lock(wvif->wdev);
    - if (!schedule_work(&wvif->tx_policy_upload_work)) {
    - wfx_tx_queues_unlock(wvif->wdev);
    + if (!schedule_work(&wvif->tx_policy_upload_work))
    wfx_tx_unlock(wvif->wdev);
    - }
    }
    return rate_id;
    }
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-04-01 13:05    [W:4.356 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site