Messages in this thread Patch in this message | | | Date | Wed, 1 Apr 2020 12:17:14 +0200 | Subject | [PATCH] checkpatch: Warn about data_race() without comment | From | Marco Elver <> |
| |
Warn about applications of data_race() without a comment, to encourage documenting the reasoning behind why it was deemed safe.
Suggested-by: Will Deacon <will@kernel.org> Signed-off-by: Marco Elver <elver@google.com> --- scripts/checkpatch.pl | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a63380c6b0d2..48bb9508e300 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -5833,6 +5833,14 @@ sub process { } } +# check for data_race without a comment. + if ($line =~ /\bdata_race\s*\(/) { + if (!ctx_has_comment($first_line, $linenr)) { + WARN("DATA_RACE", + "data_race without comment\n" . $herecurr); + } + } + # check for smp_read_barrier_depends and read_barrier_depends if (!$file && $line =~ /\b(smp_|)read_barrier_depends\s*\(/) { WARN("READ_BARRIER_DEPENDS", -- 2.26.0.rc2.310.g2932bb562d-goog
| |