lkml.org 
[lkml]   [2020]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: linux-next: build failure after merge of the gpio tree
    Hi Stephen, LinusW,

    On Wed, Apr 1, 2020 at 6:21 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
    > From: Stephen Rothwell <sfr@canb.auug.org.au>
    > Date: Wed, 1 Apr 2020 15:14:32 +1100
    > Subject: [PATCH] gpio: export of_pinctrl_get to modules
    >
    > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

    Thanks for your patch, which I assume is a quick build fix.
    I see LinusW has already applied it...

    > --- a/drivers/pinctrl/devicetree.c
    > +++ b/drivers/pinctrl/devicetree.c
    > @@ -103,6 +103,7 @@ struct pinctrl_dev *of_pinctrl_get(struct device_node *np)
    > {
    > return get_pinctrl_dev_from_of_node(np);
    > }
    > +EXPORT_SYMBOL_GPL(of_pinctrl_get);
    >
    > static int dt_to_map_one_config(struct pinctrl *p,
    > struct pinctrl_dev *hog_pctldev,

    As exporting symbols has its (space) cost, and of_pinctrl_get() is a tiny
    function, what about making it an inline function in
    include/linux/pinctrl/pinctrl.h instead?

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2020-04-01 09:49    [W:3.339 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site