Messages in this thread | | | Date | Wed, 1 Apr 2020 00:10:23 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH 2/3] net: qrtr: Add MHI transport layer |
| |
On Tue 31 Mar 23:44 PDT 2020, Manivannan Sadhasivam wrote: > diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c [..] > +static void qcom_mhi_qrtr_ul_callback(struct mhi_device *mhi_dev, > + struct mhi_result *mhi_res) > +{ > + struct sk_buff *skb = (struct sk_buff *)mhi_res->buf_addr; > + > + consume_skb(skb); > + if (skb->sk) > + sock_put(skb->sk);
Don't you need to do this in opposite order, to avoid a use after free?
Regards, Bjorn
| |