Messages in this thread | | | Date | Mon, 09 Mar 2020 19:58:04 +0100 | From | Michael Walle <> | Subject | Re: [PATCH 6/6] arm64: dts: ls1028a-rdb: Add a spidev node for the mikroBUS |
| |
Am 2020-03-09 19:50, schrieb Vladimir Oltean: > On Mon, 9 Mar 2020 at 20:35, Michael Walle <michael@walle.cc> wrote: >> >> Am 2020-03-09 15:56, schrieb Vladimir Oltean: >> > From: Vladimir Oltean <vladimir.oltean@nxp.com> >> > >> > For debugging, it is useful to have access to the DSPI controller >> > signals. On the reference design board, these are exported to either >> > the >> > mikroBUS1 or mikroBUS2 connector (according to the CPLD register >> > BRDCFG3[SPI3]). >> > >> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> >> > --- >> > arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 14 ++++++++++++++ >> > 1 file changed, 14 insertions(+) >> > >> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts >> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts >> > index bb7ba3bcbe56..43f403b30dae 100644 >> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts >> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts >> > @@ -83,6 +83,20 @@ >> > }; >> > }; >> > >> > +&dspi2 { >> > + bus-num = <2>; >> > + status = "okay"; >> > + >> > + /* mikroBUS1 */ >> > + spidev@0 { >> > + compatible = "spidev"; >> >> As far as I know this throws a warning at boot that you >> shouldn't use the compatible = "spidev", doesn't it? >> >> /* >> * spidev should never be referenced in DT without a specific >> * compatible string, it is a Linux implementation thing >> * rather than a description of the hardware. >> */ >> > > If this is supposed to mean that the "spidev" string is less > adequate/expressive than "rohm,dh2228fv", then ok, I'll use that.
TBH I don't care, its your board ;) But I suppose that there is no Rohm DH2228FV on the (pluggable) mikroBUS board. I just noticed that compatible string. Don't shoot the messenger ;)
-michael
> >> -michael >> >> > + reg = <0>; >> > + spi-max-frequency = <20000000>; >> > + fsl,spi-cs-sck-delay = <100>; >> > + fsl,spi-sck-cs-delay = <100>; >> > + }; >> > +}; >> > + >> > &esdhc { >> > sd-uhs-sdr104; >> > sd-uhs-sdr50;
| |