lkml.org 
[lkml]   [2020]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v8 1/8] include: fpga: adi-axi-common.h: fixup whitespace tab -> space
Date
On Sat, 2020-03-07 at 11:56 -0800, Moritz Fischer wrote:
> On Sat, Mar 07, 2020 at 02:25:21PM +0000, Jonathan Cameron wrote:
> > On Fri, 6 Mar 2020 13:00:53 +0200
> > Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> >
> > > The initial version use a tab between '#define' & 'ADI_AXI_REG_VERSION'.
> > > This changes it to space. The change is purely cosmetic.
> > >
> > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Acked-by: Moritz Fischer <mdf@kernel.org>

I'm still a bit vague on who maintains what.
The initial version of this header did not get submitted to Moritz's attention
Apologies for that.

It came to exist as a result of upstreaming parts of the ADI AXI DMAC driver.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d27ac2e02bf256d4e824e7c1e1e1afa2b96cefcc

The initial complaint was that some magic numbers were used and then I added
this header, which is a smaller version of the one we have in the ADI tree.

Thanks
Alex

>
> > Whilst this is trivial it still needs an ack from relevant maintainer
> > for that directory. Moritz I think...
> >
> > Jonathan
> >
> > > ---
> > > include/linux/fpga/adi-axi-common.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/include/linux/fpga/adi-axi-common.h b/include/linux/fpga/adi-
> > > axi-common.h
> > > index 7fc95d5c95bb..ebd4e07ae3d8 100644
> > > --- a/include/linux/fpga/adi-axi-common.h
> > > +++ b/include/linux/fpga/adi-axi-common.h
> > > @@ -11,7 +11,7 @@
> > > #ifndef ADI_AXI_COMMON_H_
> > > #define ADI_AXI_COMMON_H_
> > >
> > > -#define ADI_AXI_REG_VERSION 0x0000
> > > +#define ADI_AXI_REG_VERSION 0x0000
> > >
> > > #define ADI_AXI_PCORE_VER(major, minor, patch) \
> > > (((major) << 16) | ((minor) << 8) | (patch))
\
 
 \ /
  Last update: 2020-03-09 14:50    [W:0.055 / U:1.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site