lkml.org 
[lkml]   [2020]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 6/7] mm/sparse.c: move subsection_map related codes together
On 03/09/20 at 10:08am, David Hildenbrand wrote:
> On 07.03.20 09:42, Baoquan He wrote:
> > No functional change.
> >
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > ---
> > mm/sparse.c | 134 +++++++++++++++++++++++++---------------------------
> > 1 file changed, 65 insertions(+), 69 deletions(-)

>
> IMHO, we don't need this patch - but just my personal opinion. Change
> itself looks good on a quick glance.

I personally like seeing function set operating on one data structure
being put together. To me, I use vi+ctags+cscope to jump to called
funtion easily. When try to get a picture of a data and handling, e.g here
the subsection map and the relevant functions, putting them together is
better to understand code. I am also fine to discard this patch, no
patch has dependency on this one in this series, it's easy to not pick
it if no one like it.

\
 
 \ /
  Last update: 2020-03-09 14:42    [W:0.067 / U:28.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site