Messages in this thread | | | Date | Mon, 9 Mar 2020 15:20:46 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH] mm: Use fallthrough; |
| |
On (20/03/08 21:51), Joe Perches wrote: > On Mon, 2020-03-09 at 13:15 +0900, Sergey Senozhatsky wrote: > > On (20/03/07 19:54), Joe Perches wrote: > > > On Sun, 2020-03-08 at 12:18 +0900, Sergey Senozhatsky wrote: > > > > On (20/03/06 23:58), Joe Perches wrote: > > > > [..]
[..]
> > > Consecutive case labels do not need an interleaving fallthrough; > > > > > > ie: ditto > > > > I see. Shall this be mentioned in the commit message, maybe? > > <shrug, maybe> I've no real opinion about that necessity. > > fallthrough commments are relatively rarely used as a > separating element between case labels. > > It's by far most common to just have consecutive case labels > without any other content. > > It's somewhere between 500:1 to 1000:1 in the kernel.
I thought that those labels were used by some static code analysis tools, so that the removal of some labels raised questions. But I don't think I have opinions otherwise.
-ss
| |