lkml.org 
[lkml]   [2020]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operators
From
Date
On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote:
> On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote:
> > Add space around operators for improving the code
> > readability.
>
> Hello again Shreeya.
>
> The subject isn't really quite appropriate as you
> are not doing this space around operator addition
> for the entire subsystem.
>
> IMO, the subject should be:
>
> [PATCH] staging: rtl8188eu: rtw_mlme: Add spaces around operators
>
> because you are only performing this change on this
> single file.
>
> If you were to do this for every single file in the
> subsystem, you could have many individual patches with
> the exact same subject line.

Oh yes, thanks for correcting me.
>
> And it would be good to show in the changelog that you
> have compiled the file pre and post patch without object
> code change.
>
> Also, it's good to show that git diff -w shows no source
> file changes.

okay will do this in v2.

>
> > Reported by checkpatch.pl
> >
> > Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
> > ---
> > drivers/staging/rtl8188eu/core/rtw_mlme.c | 40 +++++++++++------
> > ------
> > 1 file changed, 20 insertions(+), 20 deletions(-)
>
> When I try this using checkpatch --fix-inplace, I get
> 21 changes against the latest -next tree.
>
> What tree are you doing this against?

I am doing this against the latest -testing tree

Thanks
>
>

\
 
 \ /
  Last update: 2020-03-09 06:50    [W:0.061 / U:8.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site