Messages in this thread | | | Date | Mon, 9 Mar 2020 10:51:02 +0100 | From | Willy TARREAU <> | Subject | Re: [PATCH RFC 0/3] clean up misc device minor numbers |
| |
On Mon, Mar 09, 2020 at 10:17:44AM +0800, Zhenzhong Duan wrote: > Some the misc device minor numbers definitions spread in different > local c files, specially some are duplicate number with different > name, some are same name with conflict numbers, some prefer dynamic > minors. > > This patchset try to address all of them.
Thanks for this! When I initially created panel.c about 20 years ago I didn't even realize there was a miscdevice.h to centralize all this. It's definitely cleaner this way.
> To be honest, I didn't try build on arm or sparc arch which some > drivers depend on as I have little experience on cross-compile. > But I still checked the patch carefully to ensure it builds > in theory. Appreciate if anyone willing to test build on those arch.
So I've built for ARM to check, I could enable and successfully build these modules that you touched: charlcd, panel, applicom, devsynth, speakup_soft. The other ones might require less obvious configs to be build-tested.
Willy
| |