lkml.org 
[lkml]   [2020]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RESEND v6 02/13] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores"
    Date
    There are two ways for SDMA accessing SPBA devices: one is SDMA->AIPS
    ->SPBA(masterA port), another is SDMA->SPBA(masterC port). Please refer
    to the 'Figure 58-1. i.MX 6Dual/6Quad SPBA connectivity' of i.mx6DQ
    Reference Manual. SDMA provide the corresponding app_2_mcu/mcu_2_app and
    shp_2_mcu/mcu_2_shp script for such two options. So both AIPS and SPBA
    scripts should keep the same behaviour, the issue only caught in AIPS
    script sounds not solide.
    The issue is more likely as the ecspi errata
    ERR009165(http://www.nxp.com/docs/en/errata/IMX6DQCE.pdf):
    eCSPI: TXFIFO empty flag glitch can cause the current FIFO transfer to
    be sent twice
    So revert commit 'dd4b487b32a3' firstly.

    Signed-off-by: Robin Gong <yibin.gong@nxp.com>
    ---
    arch/arm/boot/dts/imx6qdl.dtsi | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
    index 70fb8b5..ff197b5 100644
    --- a/arch/arm/boot/dts/imx6qdl.dtsi
    +++ b/arch/arm/boot/dts/imx6qdl.dtsi
    @@ -337,7 +337,7 @@
    clocks = <&clks IMX6QDL_CLK_ECSPI1>,
    <&clks IMX6QDL_CLK_ECSPI1>;
    clock-names = "ipg", "per";
    - dmas = <&sdma 3 8 1>, <&sdma 4 8 2>;
    + dmas = <&sdma 3 7 1>, <&sdma 4 7 2>;
    dma-names = "rx", "tx";
    status = "disabled";
    };
    @@ -351,7 +351,7 @@
    clocks = <&clks IMX6QDL_CLK_ECSPI2>,
    <&clks IMX6QDL_CLK_ECSPI2>;
    clock-names = "ipg", "per";
    - dmas = <&sdma 5 8 1>, <&sdma 6 8 2>;
    + dmas = <&sdma 5 7 1>, <&sdma 6 7 2>;
    dma-names = "rx", "tx";
    status = "disabled";
    };
    @@ -365,7 +365,7 @@
    clocks = <&clks IMX6QDL_CLK_ECSPI3>,
    <&clks IMX6QDL_CLK_ECSPI3>;
    clock-names = "ipg", "per";
    - dmas = <&sdma 7 8 1>, <&sdma 8 8 2>;
    + dmas = <&sdma 7 7 1>, <&sdma 8 7 2>;
    dma-names = "rx", "tx";
    status = "disabled";
    };
    @@ -379,7 +379,7 @@
    clocks = <&clks IMX6QDL_CLK_ECSPI4>,
    <&clks IMX6QDL_CLK_ECSPI4>;
    clock-names = "ipg", "per";
    - dmas = <&sdma 9 8 1>, <&sdma 10 8 2>;
    + dmas = <&sdma 9 7 1>, <&sdma 10 7 2>;
    dma-names = "rx", "tx";
    status = "disabled";
    };
    --
    2.7.4
    \
     
     \ /
      Last update: 2020-03-10 04:30    [W:3.213 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site