Messages in this thread | | | From | "Prakhya, Sai Praneeth" <> | Subject | RE: [PATCH V1 01/13] selftests/resctrl: Fix feature detection | Date | Mon, 9 Mar 2020 22:51:14 +0000 |
| |
Hi Reinette,
> -----Original Message----- > From: Reinette Chatre <reinette.chatre@intel.com> > Sent: Monday, March 9, 2020 3:34 PM
[SNIP]
> > That's a good point and makes sense to me. I think we could fix it in > > two ways 1. grep for strings in dmesg but that will still leave > > ambiguity in deciding b/w mbm and cqm because kernel prints "resctrl: L3 > monitoring detected" for both the features 2. Check in "info" directory > > a. For cat_l3, we could search for info/L3 > > b. For mba, we could search for info/MB > > c. For cqm and mbm, we could search for specified string in > > info/L3_MON/mon_features > > > > I think option 2 might be better because it can handle all cases, please let me > know what you think. > > I agree. For the reasons you mention and also that (1) may not be possible if the > loglevel prevents those lines from being printed.
Makes sense. I will work on the fix.
Regards, Sai
| |