lkml.org 
[lkml]   [2020]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/1] pwm: mediatek: add longer period support
From
Date
Hello,

On Sun, 2020-03-08 at 21:18 +0100, Uwe Kleine-König wrote:
> Hello,
>
> On Sat, Mar 07, 2020 at 10:28:36PM +0100, Matthias Brugger wrote:
> > On 03/03/2020 11:19, Sam Shih wrote:
> > > The pwm clock source could be divided by 1625 with PWM_CON
> > > BIT(3) setting in mediatek hardware.
> > >
> > > This patch add support for longer pwm period configuration,
> > > which allowing blinking LEDs via pwm interface.
> >
> > Is this a fix? In this case please provide a Fixes tag with the commit ID which
> > introduced the bug.
>
> I'd say it qualifies as a fix if without it a request with a long period
> returns success but isn't properly implemented. Otherwise it's only a
> new feature.
>

It's only a new feature.

Without this patch, pwm_mediatek_config return -EINVAL when receive a
long period request.

I will send v3 to reply Uwe's comment.


Best Regards,
Sam Shih

\
 
 \ /
  Last update: 2020-03-09 04:37    [W:0.072 / U:54.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site