lkml.org 
[lkml]   [2020]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operator
On Mon, 9 Mar 2020, Shreeya Patel wrote:

> Add space around & operator for improving the code
> readability.

I guess you found this with checkpatch. If so, it could be nice to add
"Reported by checkpatch." to the log message. OK otherwise.

Acked-by: Julia Lawall <julia.lawall@inria.fr>

>
> Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> index e764436e120f..8da955e8343b 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c
> @@ -924,7 +924,7 @@ static void rtw_joinbss_update_network(struct adapter *padapter, struct wlan_net
> /* update fw_state will clr _FW_UNDER_LINKING here indirectly */
> switch (pnetwork->network.InfrastructureMode) {
> case Ndis802_11Infrastructure:
> - if (pmlmepriv->fw_state&WIFI_UNDER_WPS)
> + if (pmlmepriv->fw_state & WIFI_UNDER_WPS)
> pmlmepriv->fw_state = WIFI_STATION_STATE|WIFI_UNDER_WPS;
> else
> pmlmepriv->fw_state = WIFI_STATION_STATE;
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200308192152.26403-1-shreeya.patel23498%40gmail.com.
>

\
 
 \ /
  Last update: 2020-03-08 20:32    [W:0.077 / U:1.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site