lkml.org 
[lkml]   [2020]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] cvt_fallthrough: A tool to convert /* fallthrough */ comments to fallthrough;
Date


On 3/7/20 21:01, Joe Perches wrote:
> On Sat, 2020-03-07 at 15:30 -0600, Gustavo A. R. Silva wrote:
>> Some people consistently add blank lines as part of their code style,
>> and if I were
>> one of those people, I wouldn't like to have such lines removed.
>
> It's a patch generator, it's not perfect.
> Nothing is nor ever will be.

Wise words. The thing is that this is feedback over a proposed
patch.

> It's quite simple to add blank lines if that's
> what any maintainer desires.
>

I'm not sure if you are saying that it's not a problem to
update your proposed patch, or if you are suggesting that
the maintainers will have the predisposition of applying
patches that will modify their coding style and then go and
willingly fix that. I doubt the latter, though.

--
Gustavo

\
 
 \ /
  Last update: 2020-03-08 07:44    [W:0.054 / U:23.928 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site