Messages in this thread | | | Date | Sat, 7 Mar 2020 18:39:22 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCHv4 10/11] videobuf2: add begin/end cpu_access callbacks to dma-sg |
| |
On (20/03/07 10:32), Hans Verkuil wrote: > >>> +static int vb2_dma_sg_dmabuf_ops_begin_cpu_access(struct dma_buf *dbuf, > >>> + enum dma_data_direction direction) > >> > >> I suggest you use this style to avoid checkpatch warnings: > >> > >> static int > >> vb2_dma_sg_dmabuf_ops_begin_cpu_access(struct dma_buf *dbuf, > >> enum dma_data_direction direction) > > > > OK, will do. > > > > Just for information, my checkpatch doesn't warn me: > > > > $ ./scripts/checkpatch.pl outgoing/0010-videobuf2-add-begin-end-cpu_access-callbacks-to-dma-.patch > > We use the --strict option to checkpatch.
Got it.
-ss
| |